[Fix]: Sequential ordering of mod patches #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The loop you corrected was replaced in #309 and doesn't summer from the original issue you mentioned above. Good catch though. |
JonathanFeenstra
force-pushed
the
fix-sorting-and-skipping
branch
from
6bb7ee2
to
dd615d0
Compare
|
I see, I removed it to prevent conflicts. |
JonathanFeenstra
changed the title
EngineViewModel
Monitor221hz
changed the title
EngineViewModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small oversight in the
EngineViewModel:OrderBycalls are replaced withThenByso the first ordering takes precedence over the next instead of being overwritten by it.In the(This was already fixed in Bryan's PR, so I removed it).LoadAsyncmethod,iis now decremented after removing an already existingmodInfofrom the list during iteration. Otherwise, the nextmodInfowill be skipped in the following iteration since the index is based on the position in the list before the removal.