-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Integrated Settings Page #17
Comments
Test build currently active in "settings" branch. Having issue with PHP fwrite |
workflow moved to top comment. |
@jonfinley @seanvree should I add an option for live searching? So that it searches when something is being typed in the searchbox. Or do we not want it at all? (don't think performance will be very good with a lot of logs/lines....) |
We had initially thought od doing that, but found the performance suffered greatly.
… On Jun 4, 2018, at 12:48 PM, Rob Gökemeijer ***@***.***> wrote:
@jonfinley <https://github.com/jonfinley> @seanvree <https://github.com/seanvree> should I add an option for live searching? So that it searches when something is being typed in the searchbox. Or do we not want it at all? (don't think performance will be very good with a lot of logs/lines....)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWNF3-yv7B_yOcBUMSzwO_8bWO_EScLgks5t5WTNgaJpZM4O5hpe>.
|
Yep I haven't tested it myself, but I can see how badly performance would suffer. |
@rob1998 yeah, you can test it out. I think it will prob produce a memory leak, but you're welcome to try. I would test with a huge ammount of logs...at least 10 logs with at least 3MB each and max limit of above 3000. |
I would do application changelog only. |
@seanvree I see you added custom error terms, do you want those to be log specific or general? |
Humm....I would probably say just general. For example, highlight all "Warn" occurrences in yellow, same way we do "error" |
Okay, yeah so also no different colors? |
maybe we can include a class when content is being highlighted, for example warn. That way users can change colors using custom css. I think that's possible. (Just an idea for later) |
well, the best snecario would be something like Term: "error" color: "Red" |
@seanvree yeah, but that would require an array (like the logs configuration), which doesn't look very nice in alpaca Option 1: Option 2: Option 3: |
@rob1998 option 3) we wouldn't have do an array if we do it for ALL logs right? |
@rob1998 I"m making notes to the first comment/checklist. Feel free to edit. |
@seanvree
language: functionality:
style:
|
The toggle switches are NOT functional, but you can see how it might look. I haven't uploaded the code because I wanted to see what you thought. http://seanvree.com/dev/logarr-settings/ What do you guys think? @jonfinley ?
|
@seanvree jump on search: language: categories: tools option: title center: log-on container: |
BUG: add required extension:
|
BUG add to functions.php:
|
add to PHPinfo.php: extension check:
|
BUG: fix favicon.png in webmanifest.json |
CHANGE:
|
Add:
|
BUG:
|
Feature: Integrated Settings Page
STATUS: In development
Current Branch: ALPHA
Progress:
Individual setting pages:
The text was updated successfully, but these errors were encountered: