This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Adjusts the Emag's effect on the Emergency Shuttle #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first commit so im very sorry if i messed up in any way i havent dont git much sorry!!!
|
Please test that your code runs before setting the pull request to "Open" |
|
sorry! whats a unit test? |
|
A unit test is what you see down below, the section saying "All checks have passed" |
Zonespace27
suggested changes
Jul 12, 2022
nednaZ
suggested changes
Jul 15, 2022
added 2 commits
July 15, 2022 22:12
…e thing (adds EMAG_OHNO and adjusts cooldown)
|
..what |
nednaZ
suggested changes
Jul 16, 2022
code/modules/shuttle/emergency.dm
Outdated
| #define EMAG_STAY 1 | ||
| #define EMAG_SLIGHT 0.6 | ||
| #define EMAG_HEAVY 0.2 | ||
| #define EMAG_OHNO 0.1 |
There was a problem hiding this comment.
Too low.
That takes a 3 minute shuttle to 18 seconds. Might as well just keep the old one.
I'd suggest .25
code/modules/shuttle/emergency.dm
Outdated
| #define EMAG_DOUBLE 2 | ||
| #define EMAG_STAY 1 | ||
| #define EMAG_SLIGHT 0.6 | ||
| #define EMAG_HEAVY 0.2 |
There was a problem hiding this comment.
Takes a 3 minute shuttle to 36 seconds.
I'd suggest .35
Co-authored-by: nednaZ <62958508+nednaZ@users.noreply.github.com>
|
|
||
| obj_flags |= EMAGGED | ||
| SSshuttle.emergency.movement_force = list("KNOCKDOWN" = 60, "THROW" = 20)//YOUR PUNY SEATBELTS can SAVE YOU NOW, MORTAL | ||
| SSshuttle.emergency.movement_force = list("KNOCKDOWN" = 60, "THROW" = 20) //YOUR PUNY SEATBELTS can SAVE YOU NOW, MORTAL |
There was a problem hiding this comment.
was getting compile errors with this comment so added whitespace to be certain
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adjusts the emag to continuously multiply the shuttle timer, giving crewmembers more than 10 seconds to get on board once an emag is used
Why It's Good For The Game
Makes the emag less broken, especially for hijack missions
Closes #247
Testing Photographs and Procedure
Screenshots&Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
balance: tweaked the emag effect in the escape shuttle
/:cl: