Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Ports welding overlay from the other server #553

Merged
merged 10 commits into from
Jul 16, 2022

Conversation

etherware-novice
Copy link

@etherware-novice etherware-novice commented Jul 15, 2022

About The Pull Request

Makes welding sparks appear when welding a wall, ported from Citadel Station (Citadel-Station-13/Citadel-Station-13#15702)

Why It's Good For The Game

More visual input

Testing Photographs and Procedure

Screenshots&Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
:add: adds welding sparks
/:cl:

@etherware-novice
Copy link
Author

@nednaZ
Copy link
Member

nednaZ commented Jul 15, 2022

Please put the PR you ported from in the base of the PR.
Also make the changelog an "add" rather than "tweak"

Copy link
Member

@nednaZ nednaZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good outside of the extra variable.

code/game/objects/items/tools/weldingtool.dm Outdated Show resolved Hide resolved
Copy link
Member

@nednaZ nednaZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nednaZ nednaZ merged commit 6f5cf57 into Monkestation:master Jul 16, 2022
@etherware-novice etherware-novice deleted the tauweld branch July 16, 2022 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants