Glide size is now determined by cpu usage. #4146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
imo it is somewhat user facing, if the effect is making movement feel smoother, even if it's a minor one. |
Absolucy
requested changes
Nov 7, 2024
| var/error = max((last_cpu - 100) / 100 * world.tick_lag, 0) | ||
|
|
||
| for(var/atom/movable/trouble as anything in GLOB.gliding_atoms) | ||
| if(world.time >= trouble.glide_stopping_time || QDELETED(trouble)) |
There was a problem hiding this comment.
Suggested change
| if(world.time >= trouble.glide_stopping_time || QDELETED(trouble)) | |
| if(world.time >= trouble.glide_stopping_time || QDELING(trouble)) |
QDELETED(trouble) is just (isnull(trouble) || QDELING(trouble)) - and we'd runtime here anyways if trouble is null.
| // cache for sonic speed | ||
| cpu_values[cpu_index] = real_cpu | ||
| GLOB.avg_cpu_values[cpu_index] = avg_cpu | ||
| GLOB.cpu_index = WRAP(cpu_index + 1, 1, CPU_SIZE + 1) |
There was a problem hiding this comment.
Suggested change
| GLOB.cpu_index = WRAP(cpu_index + 1, 1, CPU_SIZE + 1) | |
| WRAP_UP(GLOB.cpu_index, CPU_SIZE + 1) |
double check that it's the same tho, just to be 100% sure
There was a problem hiding this comment.
Would need to run a few number tests but I think WRAP_UP would be different
Co-authored-by: Lucy <lucy@absolucy.moe>
|
have you gotten anywhere with this? I was unable to satisfyingly update glide size mid movement to account for ticks. needed to burn more time working out the exact timings. if you have I would like to steal that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Non player facing change so no CL
tgstation/tgstation#85971
Why It's Good For The Game
Makes movement feel smoother
Changelog
🆑
/:cl: