[Code Bounty] Unreviewed Mixtape Refund + Bonus #4414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Absolucy thing |
Coll6
changed the title
Absolucy
requested changes
Dec 17, 2024
Absolucy
approved these changes
Dec 20, 2024
Merged
Gw0sty
pushed a commit
to Gw0sty/Monkestation2.0
that referenced
this pull request
Jan 9, 2025
* Refunds coin on unreviewed cassettes at end round * Fixes refund not returned when different mob * Fix small bug preventing tape from being destroyed * Slight formatting for clarity. * Merge conflict fix. * Adds base for admin review cassettes verb in menu * Change to TGUI using a fun menu as a base. * Interface implemented and basic funcs working. * Interfaceshows if a cassette is denied or approved * Slight refactor. Fixed Reveiwed UI spam + Features * Refactor jsx to jtx * Applies suggestions.
Gw0sty
pushed a commit
to Gw0sty/Monkestation2.0
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This adds to the end game refunds for any mixtapes that went unreviewed by an admin during the shift. Unreviewed is considered one that has not been marked Approved or Denied by an admin. If it isn't reviewed and the shift ends the player gets their monkecoins back and is informed which tapes they are getting refunded for. Fixes small error with the cassette_review Destroy proc error on runtime due to a type mismatch preventing the global review tape list from removing items when it should.
Bonus!
This also adds a new menu and command for admins. The menu will allow them to see what cassettes have been submitted during the shift. It will also show whether they are pending, approved, or denied with nifty colors to match. Finally the menu allows admins to open, the review menu for the specific tape they wish to review. If the tape was already reviewed by an admin it'll allow them to still view who submitted it and what songs their tape contains.
Why It's Good For The Game
Currently if any tape goes unreviewed when a round ends the 5k monkecoins spent on getting the mixtape reviewed is just lost. The player is also not even informed of this until they check their account in the next game. Making this amount does take a few shifts doing bounties to earn but it is a let down to lose it. Admins can get busy at any point of a round and it is possible some mixtapes will go unreviewed. Players shouldn't feel punished for something out of everyone's hands. This would ultimately end up encouraging Curators into making more mixtapes.
The new menu is helpful as currently the only way to open a review is to click the link in chat. If that disappears without some monkey business it basically cannot be reviewed. The menu allows the user to reopen reviews at any time and get an overview of what was submitted. Even better they don't even have to join the game. It all can be done from the lobby. This menu change also fixes a bug where an admin opens up a review on an already reviewed tape causing the tgui screen to continuously pop up a tgui alert. This alert has been removed completely for the new menu and tape review menu will disable it's buttons to prevent changing its status after the fact.
Bounty Discord Link: Bounty
Example End Text
Changelog
🆑Siro
add: Refunding of unreviewed mixtapes at round end
add: Cassette Manager interface
add: Admin.Games Review Cassettes to the admin menu
del: tgui alert for already reviewed cassettes
fix: tgui alert spamming the client when attempting to review an already reviewed cassette.
fix: Runtime error on cassette_review Destroy proc
/:cl: