Feature/#106 fmt function #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 17, 2018 00:00
…ature/#106_fmt_function
…ature/#106_fmt_function
…ature/#106_fmt_function
ziflex
reviewed
Oct 29, 2018
pkg/stdlib/strings/fmt.go
Outdated
| return values.NewString(formatted), nil | ||
| } | ||
|
|
||
| func format(template string, args ...core.Value) (string, error) { |
There was a problem hiding this comment.
Could you change args ...core.Value to args []core.Value?
There was a problem hiding this comment.
Sure. But what's the difference?
There was a problem hiding this comment.
Because variadic functions create a new slice. Extra unnecessary work.
ziflex
reviewed
Oct 29, 2018
pkg/stdlib/strings/fmt.go
Outdated
| func format(template string, args ...core.Value) (string, error) { | ||
| rgx, err := regexp.Compile("{[0-9]*}") | ||
| if err != nil { | ||
| return "", fmt.Errorf("failed to build regexp: %v", err) |
There was a problem hiding this comment.
Let's be consistent in terms of errors. Could you use https://github.com/pkg/errors instead of fmt?
ziflex
requested changes
Oct 29, 2018
|
Great job! Thank you for your time and efforts! |
|
Closes #106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.