Changed logic of iterator termination #330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, if iterator returned
NONE
value, it meant, that this is the end of iteration and there are no values.This approach has one big flaw - it does not work in scenarios, when an underlying source contains
NONE
values.This PR changes it. Now, whenever iterator gets exhausted it returns
core.NoMoreData
error and all consumers should check output on this error.Before:
Now: