feat: add environment variables for tag database and schema #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 13, 2023 09:51
|
Hi @jamesweakley, any chance this could be reviewed? This feature would be really useful for us. Really appreciate the work you've done on this package. |
|
Hi @arjunthangaraj, apologies for the delay. The change looks good to me, thanks for contributing it. I can't approve the merge but hopefully @JFrackson or another maintainer can. |
|
Hi @JFrackson, @mbhoopathy, @alfredodimassimo. Any chance we can get some reviews on this? :) Thanks |
|
Hi @JFrackson @alfredodimassimo @mbhoopathy , Could we get some reviews on this please? Thanks. |
|
Thanks for this change and sorry about the delay with the review! Merging and releasing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for adding the environment variables for tag database and schema which should allow users to create the tag in different centralised location and use it in the models. This is for the issue mentioned here.
If not given any environment variables, the existing functionality will not get affected and tags will be created in the same database and schema as models.
README.md has been updated with the details and it is tested with the sample model on dbt v1.6.