fs: fix options.end of fs.ReadStream()

Add a test. Fixes: nodejs#18116
MoonBall · Jan 13, 2018 · 1981fbf · 1981fbf
1 parent 036b29b
commit 1981fbf
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/fs.js b/lib/fs.js
@@ -2236,7 +2236,7 @@ function ReadStream(path, options) {
   this.flags = options.flags === undefined ? 'r' : options.flags;
   this.mode = options.mode === undefined ? 0o666 : options.mode;
 
-  this.start = (typeof this.fd !== 'number' && options.start === undefined) ?
+  this.start = typeof this.fd !== 'number' && options.start === undefined ?
     0 : options.start;
   this.end = options.end;
   this.autoClose = options.autoClose === undefined ? true : options.autoClose;

diff --git a/test/sequential/test-stream2-fs.js b/test/sequential/test-stream2-fs.js
@@ -68,3 +68,16 @@ w.on('results', function(res) {
 });
 
 r.pipe(w);
+
+const optionsEnd = 3;
+const optionsEndExpectLength = optionsEnd + 1;
+const rOfEnd = new FSReadable(file, {
+  end: optionsEnd,
+});
+const wOfEnd = new TestWriter();
+
+wOfEnd.on('results', function(res) {
+  assert.strictEqual(wOfEnd.length, optionsEndExpectLength);
+});
+
+rOfEnd.pipe(wOfEnd);