Fix error when switching geom type in geometry collection

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
MoonE · Aug 26, 2023 · b04ea44 · b04ea44
1 parent 00d1774
commit b04ea44
Show file tree

Hide file tree

Showing 4 changed files with 79 additions and 6 deletions.
diff --git a/libraries/classes/Gis/GisMultiLineString.php b/libraries/classes/Gis/GisMultiLineString.php
@@ -298,7 +298,7 @@ public function prepareRowAsOl($spatial, int $srid, $label, $line_color, array $
      */
     public function generateWkt(array $gis_data, $index, $empty = '')
     {
-        $data_row = $gis_data[$index]['MULTILINESTRING'];
+        $data_row = $gis_data[$index]['MULTILINESTRING'] ?? null;
 
         $no_of_lines = $data_row['no_of_lines'] ?? 1;
         if ($no_of_lines < 1) {

diff --git a/libraries/classes/Gis/GisMultiPolygon.php b/libraries/classes/Gis/GisMultiPolygon.php
@@ -377,7 +377,7 @@ private function drawPath($polygon, array $scale_data)
      */
     public function generateWkt(array $gis_data, $index, $empty = '')
     {
-        $data_row = $gis_data[$index]['MULTIPOLYGON'];
+        $data_row = $gis_data[$index]['MULTIPOLYGON'] ?? null;
 
         $no_of_polygons = $data_row['no_of_polygons'] ?? 1;
         if ($no_of_polygons < 1) {

diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -6969,10 +6969,9 @@
       <code>$temp_point[1]</code>
       <code>$wkt</code>
     </MixedArgument>
-    <MixedArrayAccess occurrences="22">
+    <MixedArrayAccess occurrences="21">
       <code>$data_row[$i]</code>
       <code>$data_row['no_of_lines']</code>
-      <code>$gis_data[$index]['MULTILINESTRING']</code>
       <code>$point['x']</code>
       <code>$point['y']</code>
       <code>$point[0]</code>
@@ -7030,6 +7029,10 @@
       <code>$black</code>
       <code>$color</code>
     </PossiblyFalseArgument>
+    <PossiblyNullArrayAccess occurrences="2">
+      <code>$data_row[$i]</code>
+      <code>$data_row['no_of_lines']</code>
+    </PossiblyNullArrayAccess>
     <RedundantPropertyInitializationCheck occurrences="1">
       <code>isset(self::$instance)</code>
     </RedundantPropertyInitializationCheck>
@@ -7120,11 +7123,10 @@
       <code>$ring['points']</code>
       <code>$wkt</code>
     </MixedArgument>
-    <MixedArrayAccess occurrences="38">
+    <MixedArrayAccess occurrences="37">
       <code>$data_row[$k]</code>
       <code>$data_row[$k]</code>
       <code>$data_row['no_of_polygons']</code>
-      <code>$gis_data[$index]['MULTIPOLYGON']</code>
       <code>$innerPoint['x']</code>
       <code>$innerPoint['y']</code>
       <code>$label_point[0]</code>
@@ -7229,6 +7231,11 @@
       <code>$black</code>
       <code>$color</code>
     </PossiblyFalseArgument>
+    <PossiblyNullArrayAccess occurrences="3">
+      <code>$data_row[$k]</code>
+      <code>$data_row[$k]</code>
+      <code>$data_row['no_of_polygons']</code>
+    </PossiblyNullArrayAccess>
     <RedundantPropertyInitializationCheck occurrences="1">
       <code>isset(self::$instance)</code>
     </RedundantPropertyInitializationCheck>

diff --git a/test/classes/Gis/GisGeometryCollectionTest.php b/test/classes/Gis/GisGeometryCollectionTest.php
@@ -116,6 +116,72 @@ public function providerForGenerateWkt(): array
         ];
 
         return [
+            [
+                [
+                    'gis_type' => 'GEOMETRYCOLLECTION',
+                    'srid' => '0',
+                    'GEOMETRYCOLLECTION' => ['geom_count' => '1'],
+                    0 => ['gis_type' => 'POINT'],
+                ],
+                0,
+                null,
+                'GEOMETRYCOLLECTION(POINT( ))',
+            ],
+            [
+                [
+                    'gis_type' => 'GEOMETRYCOLLECTION',
+                    'srid' => '0',
+                    'GEOMETRYCOLLECTION' => ['geom_count' => '1'],
+                    0 => ['gis_type' => 'LINESTRING'],
+                ],
+                0,
+                null,
+                'GEOMETRYCOLLECTION(LINESTRING( , ))',
+            ],
+            [
+                [
+                    'gis_type' => 'GEOMETRYCOLLECTION',
+                    'srid' => '0',
+                    'GEOMETRYCOLLECTION' => ['geom_count' => '1'],
+                    0 => ['gis_type' => 'POLYGON'],
+                ],
+                0,
+                null,
+                'GEOMETRYCOLLECTION(POLYGON(( , , , )))',
+            ],
+            [
+                [
+                    'gis_type' => 'GEOMETRYCOLLECTION',
+                    'srid' => '0',
+                    'GEOMETRYCOLLECTION' => ['geom_count' => '1'],
+                    0 => ['gis_type' => 'MULTIPOINT'],
+                ],
+                0,
+                null,
+                'GEOMETRYCOLLECTION(MULTIPOINT( ))',
+            ],
+            [
+                [
+                    'gis_type' => 'GEOMETRYCOLLECTION',
+                    'srid' => '0',
+                    'GEOMETRYCOLLECTION' => ['geom_count' => '1'],
+                    0 => ['gis_type' => 'MULTILINESTRING'],
+                ],
+                0,
+                null,
+                'GEOMETRYCOLLECTION(MULTILINESTRING(( , )))',
+            ],
+            [
+                [
+                    'gis_type' => 'GEOMETRYCOLLECTION',
+                    'srid' => '0',
+                    'GEOMETRYCOLLECTION' => ['geom_count' => '1'],
+                    0 => ['gis_type' => 'MULTIPOLYGON'],
+                ],
+                0,
+                null,
+                'GEOMETRYCOLLECTION(MULTIPOLYGON((( , , , ))))',
+            ],
             [
                 $temp1,
                 0,