Hub75 virtual matrix panel #185
Draft
+51
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght count are set
netmindz
commented
Nov 14, 2024
| if(mxconfig.chain_length > 1 && rows >= 1 && cols >= 1) { // More than 1 panel, not just horizontal layout | ||
| // TODO: special case of 128x64 panels actually being 64x64 chain of two internally | ||
| USER_PRINTF("MatrixPanel_I2S_DMA VirtualMatrixPanel %ux%u - %ux%u\n", mxconfig.mx_width, mxconfig.mx_height, rows, cols); | ||
| virtualDisp = new VirtualMatrixPanel((*display), rows, cols, mxconfig.mx_width, mxconfig.mx_height, (PANEL_CHAIN_TYPE)bc.skipAmount); |
There was a problem hiding this comment.
192x128 total was chain 6 - 2, 3, 64, 64, CHAIN_BOTTOM_RIGHT_UP (4)
netmindz
commented
Nov 14, 2024
Comment on lines
+394
to
+395
| pinArray[3] = rows; | ||
| pinArray[4] = cols; |
There was a problem hiding this comment.
no getters in the VirtualDisplay to read these values back out again, might do a PR at some stage to add that
|
It should be ready for testing (currently untested at all with hardware), at the moment you need to edit the json to set the pin values and skipCount hijacked for the chain layout type |
|
@netmindz the overall idea is to replace "chain length" by "panel cols" and "panel rows", right? |
|
Yeah good thinking, we can calculate chain length by row * cols |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use VirtualMatrixPanel when there is a chain of more than 1 and panel horizontal count and panel vertical count are set