Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioLux Usermod #80

Draft
wants to merge 13 commits into
base: mdev
Choose a base branch
from
Draft

AudioLux Usermod #80

wants to merge 13 commits into from

Conversation

netmindz
Copy link
Collaborator

@softhack007
Copy link
Collaborator

softhack007 commented Oct 12, 2023

Hi, took a quick look at compile errors.

libdeps/esp32_4MB_M_debug/Audiolux/curtain.cpp:4:18: fatal error: Math.h: No such file or directory

This seems to be a bug in the library. Math.h does not exist, it has to be math.h (all lower case). Might work on WinDoze which is case insensitive, but linux hosted builds will surely fail.

Edit: just created a bug report for AudioLux

@netmindz
Copy link
Collaborator Author

As mentioned a while back, I've now started to try and create a usermod in WLED to pull in some of what this code provides to WLED #80

@netmindz
Copy link
Collaborator Author

I've added a couple of effects as just quick PoC of the structure of how to wire in the library

Need to look at the docs and the https://github.com/netmindz/Audiolux/tree/master/examples to really see what effects we want that use this

@@ -1023,6 +1030,7 @@ lib_deps = ${esp32_4MB_S_base.lib_deps} ${common_mm.lib_deps_M}
[esp32_4MB_XL_base]
extends = esp32_4MB_M_base
build_flags = ${esp32_4MB_M_base.build_flags} ${common_mm.build_flags_XL}
build_unflags = -D USERMOD_AUDIOLUX ; Tips us over the edge
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why that isn't taking effect?

Copy link
Collaborator

@softhack007 softhack007 Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly you also need to add the library to lib_ignore. otherwise the compiler still tries to build the audiolux library even when its not needed. Can check later this aternoon...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so adding the compiled code, despite not actually being referenced. Just statically linking all parts of all libraries. Wonder if there is an option you can pass to the linker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants