-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AudioLux Usermod #80
base: mdev
Are you sure you want to change the base?
AudioLux Usermod #80
Conversation
Hi, took a quick look at compile errors.
This seems to be a bug in the library. Edit: just created a bug report for AudioLux |
As mentioned a while back, I've now started to try and create a usermod in WLED to pull in some of what this code provides to WLED #80 |
I've added a couple of effects as just quick PoC of the structure of how to wire in the library Need to look at the docs and the https://github.com/netmindz/Audiolux/tree/master/examples to really see what effects we want that use this |
@@ -1023,6 +1030,7 @@ lib_deps = ${esp32_4MB_S_base.lib_deps} ${common_mm.lib_deps_M} | |||
[esp32_4MB_XL_base] | |||
extends = esp32_4MB_M_base | |||
build_flags = ${esp32_4MB_M_base.build_flags} ${common_mm.build_flags_XL} | |||
build_unflags = -D USERMOD_AUDIOLUX ; Tips us over the edge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why that isn't taking effect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly you also need to add the library to lib_ignore
. otherwise the compiler still tries to build the audiolux library even when its not needed. Can check later this aternoon...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, so adding the compiled code, despite not actually being referenced. Just statically linking all parts of all libraries. Wonder if there is an option you can pass to the linker
Add new effects from https://github.com/CymaSpace/Audiolux