Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update linter #40

Merged
merged 16 commits into from
Aug 18, 2023
Merged

ci: update linter #40

merged 16 commits into from
Aug 18, 2023

Conversation

StarHeartHunt
Copy link
Member

No description provided.

@StarHeartHunt StarHeartHunt marked this pull request as draft August 18, 2023 02:08
github-actions[bot]
github-actions bot reviewed Aug 18, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

src/widgets/EnemiesListV2/index.vue|311 col 24| Insert ;
src/widgets/EnemiesListV2/index.vue|311 col 24| Missing semicolon.
src/widgets/EnemiesListV2/index.vue|355 col 28| Insert ;
src/widgets/EnemiesListV2/index.vue|355 col 28| Missing semicolon.
src/widgets/EnemiesListV2/index.vue|367 col 28| Insert ;
src/widgets/EnemiesListV2/index.vue|367 col 28| Missing semicolon.
src/widgets/EnemiesListV2/index.vue|379 col 28| Insert ;
src/widgets/EnemiesListV2/index.vue|379 col 28| Missing semicolon.
src/widgets/EnemiesListV2/index.vue|391 col 28| Insert ;
src/widgets/EnemiesListV2/index.vue|391 col 28| Missing semicolon.
src/widgets/EnemiesListV2/index.vue|403 col 28| Insert ;
src/widgets/EnemiesListV2/index.vue|403 col 28| Missing semicolon.
src/widgets/EnemiesListV2/index.vue|425 col 71| Insert ;
src/widgets/EnemiesListV2/index.vue|425 col 71| Missing semicolon.
src/widgets/EnemiesListV2/index.vue|433 col 46| Insert ;
src/widgets/EnemiesListV2/index.vue|433 col 46| Missing semicolon.
src/widgets/EnemiesListV2/index.vue|454 col 52| Replace sourceColumn.key]·as·string[] with ⏎··········sourceColumn.key⏎········]·as·string[];
src/widgets/EnemiesListV2/index.vue|454 col 81| Missing semicolon.

src/widgets/EnemiesListV2/index.vue Outdated
reactive,
ref,
watch,
} from "vue"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ;

Suggested change
} from "vue"
} from "vue";

src/widgets/EnemiesListV2/index.vue Outdated
reactive,
ref,
watch,
} from "vue"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.

Suggested change
} from "vue"
} from "vue";

src/widgets/EnemiesListV2/index.vue Outdated
import type {
DataTableBaseColumn,
DataTableColumn,
DataTableColumns,
DataTableFilterState,
DataTableInst,
} from 'naive-ui'
} from "naive-ui"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ;

Suggested change
} from "naive-ui"
} from "naive-ui";

src/widgets/EnemiesListV2/index.vue Outdated
import type {
DataTableBaseColumn,
DataTableColumn,
DataTableColumns,
DataTableFilterState,
DataTableInst,
} from 'naive-ui'
} from "naive-ui"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.

Suggested change
} from "naive-ui"
} from "naive-ui";

src/widgets/EnemiesListV2/index.vue Outdated
import { getImagePath } from '@/utils/utils'
import { getNaiveUILocale } from '@/utils/i18n'
import { useThemeStore } from '@/stores/theme'
} from "naive-ui"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ;

Suggested change
} from "naive-ui"
} from "naive-ui";

src/widgets/EnemiesListV2/index.vue Outdated
(e.children[1] as HTMLElement).style.display = 'block'
document.querySelectorAll(".mc-tooltips").forEach((e) => {
if (!e.children || e.children.length < 2) return
;(e.children[1] as HTMLElement).style.display = "block"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ;(e.children[1]·as·HTMLElement).style.display·=·"block" with (e.children[1]·as·HTMLElement).style.display·=·"block";

Suggested change
;(e.children[1] as HTMLElement).style.display = "block"
(e.children[1] as HTMLElement).style.display = "block";

src/widgets/EnemiesListV2/index.vue Outdated
(e.children[1] as HTMLElement).style.display = 'block'
document.querySelectorAll(".mc-tooltips").forEach((e) => {
if (!e.children || e.children.length < 2) return
;(e.children[1] as HTMLElement).style.display = "block"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.

Suggested change
;(e.children[1] as HTMLElement).style.display = "block"
;(e.children[1] as HTMLElement).style.display = "block";

src/widgets/EnemiesListV2/index.vue Outdated
(e.children[1] as HTMLElement).dataset.trigger
|| 'mouseenter focus',
(e.children[1] as HTMLElement).dataset.trigger ||
"mouseenter focus",
})
})
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.

Suggested change
})
});

src/widgets/EnemiesListV2/index.vue Outdated
})
})
})
return h('span', { innerHTML: row.ability })
return h("span", { innerHTML: row.ability })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ;

Suggested change
return h("span", { innerHTML: row.ability })
return h("span", { innerHTML: row.ability });

src/widgets/EnemiesListV2/index.vue Outdated
})
})
})
return h('span', { innerHTML: row.ability })
return h("span", { innerHTML: row.ability })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.

Suggested change
return h("span", { innerHTML: row.ability })
return h("span", { innerHTML: row.ability });

@StarHeartHunt StarHeartHunt marked this pull request as ready for review August 18, 2023 03:10
github-actions[bot]
github-actions bot reviewed Aug 18, 2023
View reviewed changes
vite.config.ts
},
plugins: [
{
name: 'prts',
name: "prts",
generateBundle(opts, bundle) {
const bundles = Object.keys(bundle)
const fileNames = ['vendor', 'naive-ui', 'common']
.map((name) => {
return bundles.find(v => v.startsWith(name))!
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.

Suggested change
})
});

@StarHeartHunt StarHeartHunt merged commit 8833a2c into main Aug 18, 2023
2 of 3 checks passed
@StarHeartHunt StarHeartHunt deleted the ci/update-linter branch August 18, 2023 03:15
StarHeartHunt added a commit to ZSLNAAKII/prts-widgets that referenced this pull request Aug 18, 2023
@StarHeartHunt
ci: update linter (MooncellWiki#40)
2ade101 
* ci: update linter

* ci: linter ignore spine runtime

* style: enable prettier semi

* chore(deps): add missing ts eslint deps

* ci: update tsconfig for build tools config

* ci: add missing semi config in eslint

* ci: add stylelint config

* style: reformat code

* ci: remove no console rule

* chore: update `.gitignore`

* chore: add `.stylelintignore`

* style: reformat build tools config

* ci: update lint action

* style: fix lint

* ci: change `vue-tsc` reporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@daflyinbed daflyinbed Awaiting requested review from daflyinbed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@StarHeartHunt