test: MSP move bucket reject on max capacity exceeded #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowmead
requested changes
Jan 16, 2025
| `--max-storage-capacity=${options?.maxStorageCapacity}`, | ||
| `--jump-capacity=${options?.jumpCapacity}`, | ||
| "--msp-charging-period=12", | ||
| "--database-url=postgresql://postgres:postgres@docker-sh-postgres-1:5432/storage_hub", |
There was a problem hiding this comment.
every MSP container we spawn relies on the same postgres database index?
| }); | ||
|
|
||
| // Create API for MSP | ||
| const mspApi = await BspNetTestApi.create(`ws://127.0.0.1:${rpcPort}`); |
There was a problem hiding this comment.
we should rename this api object BspNetTestApi to something like ProviderNetTestApi
| @@ -337,6 +331,8 @@ export type TestOptions = { | |||
| extrinsicRetryTimeout?: number; | |||
| /** If true, runs launched userNode has attached indexer service enabled. */ | |||
| indexer?: boolean; | |||
| /** Set a custom max storage capacity for MSP2 */ | |||
| msp2MaxStorageCapacity?: number; | |||
There was a problem hiding this comment.
I don't see this being used anywhere
Comment on lines
+411
to
+414
| pricePerGigaUnitOfDataPerBlock: 100 * 1024 * 1024, | ||
| commitment: "Terms of Service...", | ||
| maxDataLimit: 9999999, | ||
| paymentAccount: who |
There was a problem hiding this comment.
we can omit these fields since they are defaults in the forceSignupMsp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to test proper rejection of move bucket request on low capacity, a refactor and addition of onboardMsp (similar to onboardBsp) was needed.
This PR builds on top of #318.