Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "sol" to AuthType (Typescript) #194

Merged
merged 2 commits into from
Feb 7, 2022
Merged

add "sol" to AuthType (Typescript) #194

merged 2 commits into from
Feb 7, 2022

Conversation

comingAlive
Copy link
Contributor


name: "Pull request"
about: A new pull request

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

TypeScript throws an error when using authenticate from the useMoralis hook with { type: "sol" }.

Solution Description

Add "sol" to AuthType in _useMoralisAuth.ts

@ErnoW
Copy link
Member

ErnoW commented Feb 7, 2022

Good one, I actually think we can import the type from the moralis SDK by using

MoralisType.AuthenticationType

@comingAlive
Copy link
Contributor Author

updated

@ErnoW
Copy link
Member

ErnoW commented Feb 7, 2022

Nice, thanks!

@ErnoW ErnoW merged commit 21670cb into MoralisWeb3:main Feb 7, 2022
ErnoW pushed a commit that referenced this pull request Feb 7, 2022
## [1.2.5](v1.2.4...v1.2.5) (2022-02-07)

### Bug Fixes

* add "sol" to AuthType (Typescript) ([#194](#194)) ([21670cb](21670cb))
@ErnoW
Copy link
Member

ErnoW commented Feb 7, 2022

🎉 This PR is included in version 1.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ErnoW ErnoW added the released label Feb 7, 2022
@comingAlive comingAlive deleted the add-sol-to-AuthType branch February 8, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants