-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Length rule #24
Open
mboiev
wants to merge
9
commits into
Morebec:dev
Choose a base branch
from
mboiev:Length
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Length rule #24
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
24571c6
added message functionality to maxlength rule
mboiev 8c3b79e
Added ContainsNumericCharactersRule
mboiev 9867e5e
Revert "Added ContainsNumericCharactersRule"
mboiev 69cbfa9
Added length rule
mboiev 9101edf
Revert "added message functionality to maxlength rule"
mboiev c5ca362
Revert "added message functionality to maxlength rule"
mboiev 0f233c6
Fixed pull request requirements
mboiev c96be9d
Revert "Fixed pull request requirements"
mboiev edb0af8
LEngth pull requests fix
mboiev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
<?php | ||
|
||
namespace Morebec\Validator\Rule; | ||
|
||
|
||
use InvalidArgumentException; | ||
use Morebec\Validator\ValidationRuleInterface; | ||
|
||
class Length implements ValidationRuleInterface | ||
{ | ||
/** | ||
* @var int | ||
*/ | ||
private $length; | ||
/** | ||
* @var string|null | ||
*/ | ||
private $message; | ||
|
||
/** | ||
* Length constructor. | ||
* @param int $length | ||
* @param string|null $message | ||
*/ | ||
public function __construct( | ||
int $length, | ||
?string $message = null | ||
) | ||
{ | ||
if($length <0) | ||
throw new InvalidArgumentException(); | ||
$this->length = $length; | ||
jwillp marked this conversation as resolved.
Show resolved
Hide resolved
|
||
$this->message = $message; | ||
} | ||
|
||
/** | ||
* Validates a value according to this rule and returns if it is valid or not | ||
* @param mixed $v | ||
* @return bool true if valid, otherwise false | ||
*/ | ||
public function validate($v): bool | ||
{ | ||
return strlen($v) == $this->length; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In PHP, it is a best practice to test with a strict comparison: |
||
} | ||
|
||
/** | ||
* Returns the message to be used in case the validation did not pass | ||
* @param mixed $v the value that did not pass the validation | ||
* @return string | ||
*/ | ||
public function getMessage($v): string | ||
{ | ||
return $this->message?:"'${$v}' is supposed to be exactly ".$this->length." characters long"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you change supposed to 'expected'? |
||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
<?php | ||
|
||
namespace Tests\Morebec\Validator\Rule; | ||
|
||
|
||
use InvalidArgumentException; | ||
use Morebec\Validator\Rule\Length; | ||
use PHPUnit\Framework\TestCase; | ||
|
||
class LengthTest extends TestCase | ||
{ | ||
public function testValidate(){ | ||
$ruleFirst = new Length(4); | ||
$ruleSecond = new Length(4,"Custom message"); | ||
|
||
$this->assertTrue($ruleFirst->validate("test")); | ||
$this->assertFalse($ruleFirst->validate("test message")); | ||
$this->assertEquals("Custom message",$ruleSecond->getMessage("test")); | ||
$this->expectException(InvalidArgumentException::class); | ||
|
||
$ruleThird = new Length(-1); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When throwing an exception, a message should always be provided in order to inform the user why the exception was thrown without needing to look at the source code.