Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remove() to Query #1355

Closed
evanchooly opened this issue Jun 6, 2019 · 0 comments
Closed

Add remove() to Query #1355

evanchooly opened this issue Jun 6, 2019 · 0 comments
Labels
enhancement
Milestone
2.0.0

Comments

@evanchooly
Copy link
Member

evanchooly commented Jun 6, 2019 •
edited
Loading

Currently removes are done by passing Query instances to Datastore.remove(). This is an awkward API and ends up assuming things about the query to be able to delete. Moving remove() to Query will simplify both usage and implementation.
@evanchooly evanchooly added this to the 2.0.0 milestone Jun 6, 2019
@evanchooly evanchooly changed the title Add delete() to Query Add remove() to Query Jun 6, 2019
evanchooly added a commit that referenced this issue Jun 6, 2019
@evanchooly
Add remove() to Query
1faa48b 
fixes #1355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@evanchooly