Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Datasource accessible in @EntityListeners [moved] #439

Closed
jyemin opened this issue Apr 25, 2013 · 2 comments
Closed

make Datasource accessible in @EntityListeners [moved] #439

jyemin opened this issue Apr 25, 2013 · 2 comments
Milestone

Comments

@jyemin
Copy link
Contributor

jyemin commented Apr 25, 2013

This is Issue 439 moved from a Google Code project.
Added by 2012-11-02T15:47:24.000Z by jmhed...@gmail.com.
Please review that bug for more context and additional comments, but update this bug.

Original labels: Type-Defect, Priority-Low

Original description

What version are you using? 0.99

unfortunately, one isnt able to access the Datasource from within an EntityListener.
@evanchooly
Copy link
Member

It doesn't appear that any interface is enforced by @EntityListeners. Getting that Datastore (which I'm assuming is what is meant there) in would be tricky. I'm ok introducing an interface or at least a constructor requirement (maybe an optional constructor?) but that might break existing code.

Using an optional constructor might be pretty useful and probably wouldn't break anything as we'd just fall back to the empty constructor.

@evanchooly evanchooly added this to the post-1.0 milestone Mar 1, 2014
@evanchooly evanchooly removed this from the post-1.0 milestone Jan 14, 2016
@evanchooly evanchooly modified the milestone: 1.3.0 Jun 13, 2016
@evanchooly
Copy link
Member

I looked in to this and even had it mostly working. Unfortunately, it requires several changes to public APIs that can't be mitigated by simple overloads. I'm afraid this one will have to wait.

@evanchooly evanchooly modified the milestones: 2.0, 1.3.0 Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants