#1008 Support for sub queries in $lookup #1228
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to provide support for the new 3.6 sub-queries in the $lookup aggregation stage as documented in https://docs.mongodb.com/manual/reference/operator/aggregation/lookup/#join-conditions-and-uncorrelated-sub-queries. Test case is taken from the official documentation at: https://docs.mongodb.com/manual/reference/operator/aggregation/lookup/#join-conditions-and-uncorrelated-sub-queries
I was and still am really unsure about the interface because of the let parameter being just a BasicDBObject. It's usage came in quite handy for me, at least handier than a Map<String, String>. As I am not that deep into the depths of Morphia interfaces, I might have overlooked any similar interface where one would have to use a simple map. Happy to refactor that accordingly.