Fix for file names that contain "/" and non existing subdirs #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just tested this, works for me. |
|
I noticed the whitespaces in front of the added lines are tabs when the rest of the file uses space. You might want to change the tabs to spaces for consistency. |
|
Yes, sorry. Used another machine with vim configured to use tabs |
|
I think this can be called a valid permanent fix. Because if we allow using "/" in file names (that's how motion behaved all the time), we do need to create path all the time for every call. So I will change the title of the PR to say this is a permanent fix |
tosiara
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #360 (comment)
This is a fix to unblock users who wants to use latest version
Further discussion is needed to make a standard for file names