Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GitHub Custom Navigation) Slight truncation in the icons' left side #4

Closed
darkred opened this issue Aug 10, 2016 · 6 comments
Closed

Comments

@darkred
Copy link
Collaborator

darkred commented Aug 10, 2016

Thanks for another great userscript!

I just noticed this minor issue: (using GCN 1.0.3 in FF48 x64 in win10 with GM 3.8)
there's a slight truncation in the icons' left side.

Here is a (resized) screenshot where I highlight the truncation (it's a few pixels) :
-using a clean FF profile with only (GM and) GCN-
2016-08-10_223653 2
And here is when the truncation doesn't occur:
20151010-5f4f-11e6-80b0-82a17c9bcd70

It occurs in e,g,
https://github.com/
https://github.com/Mottie/GitHub-userscripts

It doesn't occur:
https://github.com/greasemonkey
https://github.com/greasemonkey/greasemonkey/wiki

Having unread notifications (i.e. having the dot on the bell icon) or not, doesn't make a difference.,

@Mottie
Copy link
Owner

Mottie commented Aug 10, 2016

Hi @darkred!

Interesting, it seems GitHub has an overflow hidden setting on the svgs. I'll override that in the script. Please let me know if the change fixes the problem.

@darkred
Copy link
Collaborator Author

darkred commented Aug 10, 2016

Yes, it's fixed. Thanks for the quick response!

@darkred darkred closed this as completed Aug 10, 2016
@darkred
Copy link
Collaborator Author

darkred commented Sep 12, 2016

Today (probably after some GitHub layout change)
the issue unfortunately occurs again.

It occurs as before, in e,g,
https://github.com/
https://github.com/Mottie/GitHub-userscripts.

@darkred darkred reopened this Sep 12, 2016
@Mottie
Copy link
Owner

Mottie commented Sep 12, 2016

It does look like the overflow is set again, I just need to increase the specificity. Thanks for letting me know!

@Mottie
Copy link
Owner

Mottie commented Sep 12, 2016

Please try the update.

@darkred
Copy link
Collaborator Author

darkred commented Sep 12, 2016

Yes, it's fixed. Thank you.

@darkred darkred closed this as completed Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants