Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The keyboard lost some characters in IE7 & IE8 #45

Closed
tigertae opened this issue Jan 30, 2012 · 9 comments
Closed

The keyboard lost some characters in IE7 & IE8 #45

tigertae opened this issue Jan 30, 2012 · 9 comments

Comments

@tigertae
Copy link

When we use the keyboard and typing quickly on it, some characters doesn't show on the textbox.

@Mottie
Copy link
Owner

Mottie commented Jan 30, 2012

Hiya!

I'm not even should how to test for this... I have IE9 and can run it in IE7 mode, but it seems to be okay for me.

There are a lot of checks that go on when typing, and I think this just might be an issue with IE7 being a bit slower than newer browsers. So if you don't have any limitations on input or special characters to enter, maybe include an option to allow users to open the keyboard by clicking on an icon if they plan to actually type in content.

@tigertae
Copy link
Author

Hi Rob,
It doesn't seems to be the speed of IE but more the focus. If you click 3 times quickly on a number on the keyboard, the last click doesn't do anything.
cheers
Stephane Briere

@Mottie
Copy link
Owner

Mottie commented Jan 30, 2012

Actually I'm sorry, it is happening in IE9 while in IE7 and IE8 mode. I initially thought you mean typing on a real keyboard.

I think it is the javascript delay with checking for combos, etc. So I'm not sure that this issue is fixable, or if it is it might take a bit of code optimization which I don't have time to do right now.

By the way, did you know that you can just hold down the key to make it repeat?

@tigertae
Copy link
Author

Hi, The virtual keyboard do the repeat works perfectly and it is quick. What I suspect for the problem I have is the management of the event with the IE7 browser. By example, when I do the first click, the whole button 8 is in focus.Second click, there is a square inside the 8 button. I think to simulate the focus. The third click the square inside the button disappear. I think this is what it cause the problem. When I do that slowly everything is ok but quickly the last event is lost. I have attached some picture to show you what I mean. If I find a fix for that I will let you know. By the way your control is very cool and work correctly except for this problem. Thanks again Stephane Briere

@Mottie
Copy link
Owner

Mottie commented Jan 31, 2012

Hmm, ok the dotted line shouldn't stay on the button. It means the button has focus, so you actually did help me find a bug. But sadly after fixing that, IE7 still misses the third click. I'll update the plugin here in a minute and you can try to see if you notice anything different.

Mottie added a commit that referenced this issue Jan 31, 2012
@tigertae
Copy link
Author

Hi Rob,
Thanks for the fix for the focus it works great. For the problem of lost characters in IE7 I have found a quick fix. I have to change keyBinding: 'mousedown' to keyBinding: 'mouseup' in the file jquery.keyboard.js and now the characters are not lost.
Cheers

@Mottie
Copy link
Owner

Mottie commented Feb 4, 2012

Oops, I meant to comment on this issue. Thanks for sharing how you fixed the problem! :)

I seem to remember that there was an issue in some browsers with using mousedown instead of mouseup. Once my brain is on straight and loaded with caffeine, I'll do some testing and see if it might just be better to switch it.

@Mottie
Copy link
Owner

Mottie commented Feb 5, 2012

I think I'm going to leave it as mousedown. This issue is searchable so if someone else has this issue they can easily find it ;)

Thanks again!

@Mottie Mottie closed this as completed Feb 5, 2012
@tigertae
Copy link
Author

tigertae commented Feb 6, 2012

No problem, It works well for the other browsers so...
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants