Avoid javascript errors when caret extension used without a preview window #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @isfs! Thanks for your work on this! I'll take a closer look at this some time tomorrow. |
Mottie
added a commit
that referenced
this pull request
Aug 5, 2015
Avoid javascript errors when caret extension used without a preview window
Mottie
added a commit
that referenced
this pull request
Aug 5, 2015
|
Thanks, Rob. Thanks also for adding the code that removes the caret. I have a On 5/08/15 10:59 PM, Rob G wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a preview window, I was noticing a lot of "base.caret_$div is null" errors on the console. The problem was that events weren't being unbound when the caret was disabled, and since $preview is $el when there is no separate preview window, the events still fired as $el remains visible, and tried to access the nulled out property. This change simply unbinds the same events when removing the caret as are bound when adding it.