Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group-text doesn't handle "<" and ">" #1206

Closed
a-mair opened this issue May 4, 2016 · 7 comments
Closed

group-text doesn't handle "<" and ">" #1206

a-mair opened this issue May 4, 2016 · 7 comments

Comments

@a-mair
Copy link
Contributor

a-mair commented May 4, 2016

Hi,

if I use "group-text" for a column that contains cells having "<" or ">" in them like "My Self <email address>" the group header looses the "<...>" part.

Best regards
Andreas

@Mottie
Copy link
Owner

Mottie commented May 4, 2016

Hi @a-mair!

Would you please modify this demo to provide an example of the problem? Thanks!

@a-mair
Copy link
Contributor Author

a-mair commented May 5, 2016

Group by "animals" and you'll see that the "Aardvark" header looses "<test>".

@Mottie
Copy link
Owner

Mottie commented May 5, 2016

Please provide a link to the demo.

@a-mair
Copy link
Contributor Author

a-mair commented May 5, 2016

Sorry, I thought modifying and updating your demo would be enough: http://jsfiddle.net/4ac5kr3o/27/

@Mottie Mottie closed this as completed in 2631243 May 5, 2016
@Mottie
Copy link
Owner

Mottie commented May 5, 2016

The fix is now available in the master branch in the widget-grouping.js and the dist widget-grouping.min.js files.

Here is an updated demo which might take a few minutes to update the file.

@a-mair
Copy link
Contributor Author

a-mair commented May 6, 2016

Hi,

thanks for fixing the problem, but I think
var name = data.currentGroup.replace(/</g, '&lt;').replace(/>/g, '&gt');
should be
var name = data.currentGroup.replace(/</g, '&lt;').replace(/>/g, '&gt;');
(&gt replaced by &gt;)

I also noticed that I now get this error: TypeError: data.currentGroup.replace is not a function

Regards,
Andreas

@Mottie
Copy link
Owner

Mottie commented May 6, 2016

Thanks! Everything is updated now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants