Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Pager Controls Error #1276

Closed
ghost opened this issue Aug 22, 2016 · 8 comments
Closed

Custom Pager Controls Error #1276

ghost opened this issue Aug 22, 2016 · 8 comments

Comments

@ghost
Copy link

ghost commented Aug 22, 2016

I'm getting pages to the left of page 1 (e.g. 0 or -1 0) and getting a superfluous extra page at the end that does not belong (e.g. 1 | 2 | 3 | 4 where there are only three pages of results.

Examples from Issue 1:
pag_error1
pag_error2
Issue 2:
pag_error3

@Mottie
Copy link
Owner

Mottie commented Aug 22, 2016

Hi @aetna-wsa!

Please modify this demo to duplicate the issue because I can't get it to behave in that manner. Thanks!

@ghost
Copy link
Author

ghost commented Aug 23, 2016

Scratch my last comment - problem remains in IE11. I'm working on a fiddle.

@ghost
Copy link
Author

ghost commented Aug 23, 2016

Okay, here is the problem in IE.
https://jsfiddle.net/dihakz/zjte5Lgc/

@Mottie Mottie closed this as completed in a42e762 Aug 24, 2016
@Mottie
Copy link
Owner

Mottie commented Aug 24, 2016

The page numbers should no longer be out-of-range. The fix is currently only available in the master branch.

Updated demo

@Mottie
Copy link
Owner

Mottie commented Aug 24, 2016

Grrr, I think I broke a few things.

@Mottie
Copy link
Owner

Mottie commented Aug 24, 2016

Ok, now it should all be fixed.

I've also changed a few things!

  • Modified adjacentSpacer and distanceSpacer to include surrounding span element.

    // spacer for page numbers next to each other
    adjacentSpacer : '<span> | </span>',
    // spacer for page numbers away from each other (ellipsis = &amp;#133;)
    distanceSpacer : '<span> &#133; <span>',   

    this will allow you to add a class name or change the wrapping element to fit your page style

  • Using the keyboard has changed!

    • The keyboard keys will only work IF a pager element has focus.
    • The addKeyboard function now includes left, right, up, down, pageUp, pageDown, Home and End.
    • A new pageKeyStep option was added to allow setting the number of pages to skip on pageUp or pageDown.

Again, these updates are currently only available in the master branch.

Updated demo

@ghost
Copy link
Author

ghost commented Aug 24, 2016

Confirmed this is no longer an issue. Thanks, Rob!

@Mottie
Copy link
Owner

Mottie commented Sep 23, 2016

Tablesorter v2.27.7 is now available.

@Mottie Mottie closed this as completed Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant