Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort not working when custom selectorHeaders #1459

Closed
brynmrk opened this issue Sep 18, 2017 · 9 comments
Closed

Sort not working when custom selectorHeaders #1459

brynmrk opened this issue Sep 18, 2017 · 9 comments

Comments

@brynmrk
Copy link

brynmrk commented Sep 18, 2017

Hi, first thanks for this wonderful plugin. I've got a problem about sorting when I set my own selectorHeaders. Can't find any other issues related to this.

Here is my code for initialization,
count_header_index = $("#summary_count_header").index() $(".tablesorter").tablesorter({sortList: [[ count_header_index, 1 ]], selectorHeaders: "> thead th span, > thead td span"})

@Mottie
Copy link
Owner

Mottie commented Sep 18, 2017

Hi @brynmrk!

There does appear to be an error. I'll need spend some time to find the problem. Thanks for reporting it!

@Mottie Mottie added the Bug label Sep 18, 2017
@Mottie Mottie closed this as completed in ea5c242 Sep 19, 2017
@Mottie
Copy link
Owner

Mottie commented Sep 19, 2017

This has been fixed in the master branch... I still have a little work to do before the next release.

Here is a demo of it working - http://jsfiddle.net/856bzzeL/1223/

Note that the selectorSort option also needs to target the spans.

@brynmrk
Copy link
Author

brynmrk commented Oct 18, 2017

Hi @Mottie, just bumping on this since I just realized that the icon in the span doesn't change, even on your jsfiddle demo.

@Mottie
Copy link
Owner

Mottie commented Oct 18, 2017

Wow, that's odd. I could have sworn it was working. I wonder what happened.

@Mottie
Copy link
Owner

Mottie commented Oct 18, 2017

Ok, it should be working now (master branch update)... try the same demo above.

@brynmrk
Copy link
Author

brynmrk commented Oct 18, 2017

Thanks for the fast reply, I just checked the demo and I think the whole tablesorter is not working. Here is the screenshot. I've tried to refresh many times, still like this.

screen shot 2017-10-19 at 07 51 35

@Mottie
Copy link
Owner

Mottie commented Oct 19, 2017

I just tested it again and it's working for me. Are you seeing any errors in the console? Check the demo in a different browser.

@brynmrk
Copy link
Author

brynmrk commented Oct 19, 2017

Forgot to check the console, yes it's showing error on the css part since it's not using https. It's working now, Thanks 👍🏼

@Mottie
Copy link
Owner

Mottie commented Dec 13, 2017

Fixed in v2.29.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants