Fix jquery deprecations #1786
Fix jquery deprecations #1786
Conversation
|
Are there plans to merge this PR? I'm upgrading a legacy app using tablesorter to jQuery 3.6 and getting lots of migration warnings that this PR is about to solve. |
|
Any updates on this? I am also upgrading legacy app 🤣 |
|
Same situation here |
|
I'll look into this over the weekend. Thanks for your patience. |
|
Sorry, this is taking longer than I thought... so much stuff to update! |
|
Thanks for taking care of this! |
|
$.trim is another deprecated function that is not migrated in the PR yet.
|
|
pls..... new verison... thx |
Fix jquery deprecations
|
pls..... new verison... thx |
|
deleting?? :( |
|
@nagyimre1980 Sorry, we need to ship those changes in our software. All third party libraries are forked in our company account. Since I can't fork same repo from two places, I have to delete this, in order to fork our company repo and merge the changes. May be our Lead Developer will create a PR with those changes. |
|
NEW PR? |
|
Please do consider this, I don't want to go in and update the library for the bind/unbind/trim deprecation warnings I've been getting for months. Thank you if you can get to this! Thanks for the plugin, as well! |
|
This fork has the jQuery compatibility commits in it: https://github.com/DavidAnderson684/tablesorter/tree/master . If anyone wants to create a new PR on https://github.com/Mottie/tablesorter/ using those changes, then they are welcome. |
|
Hi @DavidAnderson684 |
|
@AviHafner You're confusing me with someone else, I am not a committer for |
Ths is a follow-on PR to #241 in order to fix the deprecation warnings: * `bind()` replaced by `on()` * `click(handler)` replaced by `on('click', handler)` Three deprecation warnings remain, but they are caused by the `jquery.tablesorter.js` plugin, so need to be handled upstream. Related: * Mottie/tablesorter#1786 * #166
Ths is a follow-on PR to #241 in order to fix the deprecation warnings: * `bind()` replaced by `on()` * `click(handler)` replaced by `on('click', handler)` Three deprecation warnings remain, but they are caused by the `jquery.tablesorter.js` plugin, so need to be handled upstream: * Mottie/tablesorter#1787 * Mottie/tablesorter#1786 Related: * #166
Ths is a follow-on PR to #241 in order to fix the deprecation warnings: * `bind()` replaced by `on()` * `click(handler)` replaced by `on('click', handler)` Three deprecation warnings remain, but they are caused by the `jquery.tablesorter.js` plugin, so need to be handled upstream: * Mottie/tablesorter#1787 * Mottie/tablesorter#1786 Related: * #166
Ths is a follow-on PR to #241 in order to fix the deprecation warnings: * `bind()` replaced by `on()` * `click(handler)` replaced by `on('click', handler)` Three deprecation warnings remain, but they are caused by the `jquery.tablesorter.js` plugin, so need to be handled upstream: * Mottie/tablesorter#1787 * Mottie/tablesorter#1786 Related: * #166
|
So far these are all just deprecations however they all would prevent this library from functioning with jQuery 4. I see a second beta release for jQuery 4 was released last month. I don't think it is too farfetched to think that a final release for jQuery 4 could arrive by the end of the year. Seeing that Mottie just committed a change that removes the |
Reference Issues/PRs
None
What does this implement/fix? Explain your changes
Fixing the JQuery deprecation code
Any other comments?
No