skip ajax request on sort event if serverSideSorting is disabled #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mottie
added a commit
that referenced
this pull request
Sep 30, 2013
skip ajax request on sort event if serverSideSorting is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am using the Ajax Pager with serverSideFiltering but not serverSideSorting. When i click a sort button the ajax pager is requesting a fresh copy of the data on each sortEnd event even if serverSideSorting is disabled. As the filters / page haven't changed and i am not sorting on the server then the data would not have changed, thus the extra ajax data request is redundant.
This patch will test if serverSideSorting is disabled and will not run the data ajax request on the sortEnd Event.
Note, It will still run ajax request on the filterEnd event and if serverSideFiltering has been enabled.