Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export DType to the public interface ... #7

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

milenkovicm
Copy link
Contributor

... as it could be used to restrict other types

like:

<I as ArrowPrimitiveType>::Native: DType,

I see no alternatives to exposing this trait.

@Mottl
Copy link
Owner

Mottl commented Aug 14, 2024

Yes, that's great! But you need to make the DType sealed before exposing it, because LightGBM can only work with C_API_DTYPE_FLOAT32 and C_API_DTYPE_FLOAT64. Can you add this as well?

... as it could be used to restrict other types
like

```
<I as ArrowPrimitiveType>::Native: DType,
```

No alternatives could be found.
@milenkovicm
Copy link
Contributor Author

No problem, added

@Mottl Mottl merged commit 45623f8 into Mottl:main Aug 14, 2024
3 checks passed
@milenkovicm
Copy link
Contributor Author

thanks a lot @Mottl
do you plan cutting release any time soon ?

@Mottl
Copy link
Owner

Mottl commented Aug 14, 2024

Marko, sorry, too little new features yet :) If you want something more to add, I appreciate this 👍

@milenkovicm
Copy link
Contributor Author

ok no problem @Mottl

@Mottl
Copy link
Owner

Mottl commented Aug 15, 2024

@milenkovicm, check for 1.0.4 on crates.io

@milenkovicm
Copy link
Contributor Author

thanks you very much @Mottl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants