Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing Netscape-formatted cookies ignores cookie with #HttpOnly_ flag #122

Closed
noaione opened this issue Jul 18, 2023 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@noaione
Copy link

noaione commented Jul 18, 2023

Trying to import a cookies with a #HttpOnly_ prefix will ignore that line since the code will skip anything starting with #: https://github.com/Moustachauve/cookie-editor/blob/v1.11.0/interface/popup/cookie-list.js#L302

As an example:

#HttpOnly_example.com	FALSE	/	FALSE	0	HttpOnlyTest	abc123
example.com	FALSE	/	FALSE	0	NoHttpOnlyTest	xyz987

Will only import NoHttpOnlyTest cookie but not HttpOnlyTest cookie.

firefox_TtjiMG1S9Q

@Moustachauve
Copy link
Owner

Moustachauve commented Aug 22, 2023

Yes, good find. Currently, all lines that start with # are ignored. In this case, "#HttpOnly_" seems to be a special flag that Cookie-Editor is not handling at all.

I will add support for it in the next version as a priority. Adding support for HttpOnly for netscape format is pretty important.
I will even look into adding it to the exported cookies.

@Moustachauve Moustachauve added the bug Something isn't working label Aug 22, 2023
Moustachauve added a commit that referenced this issue Aug 30, 2023
Improve detection for #110 based on hostOnly instead of '.' in the domain.
@Moustachauve
Copy link
Owner

This is now fixed in version 1.12.0! This version is slowly rolling out for all browsers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants