Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request provides several fixes, both minor and major, which improve the general usability of NUI within Destination Sol:
NUIScreenLayer#onRemoved
post-removal, rather than pre-removal. The previous behaviour was likely unintentional.NUIScreenLayer
if any of its childKeyActivatedButton
widgets consume those events.KeyActivatedButton
from unconditionally consuming up/down arrow key events.Testing
Most of these fixes come from scenarios encountered whilst porting the in-game screens to use NUI. As such, they solve problems are not yet exposed in the
develop
codebase.The following things should be testable directly with these changes though:
Notes
NUIScreenLayer#onRemoved
change is technically an breaking change in functionality, however, since there has never been a release containing NUI yet, it should not have a significant impact.