fix: fix UIButton not releasing when enabled #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
approved these changes
Sep 7, 2021
pollend
added a commit
that referenced
this pull request
Oct 5, 2021
* build(github): add 'labels.json' configuration This PR adds the label configuration to `.github/labels.json`, which can be used to sync labels with Financial-Times/github-label-sync Co-authored-by: jdrueckert <jd.rueckert@googlemail.com> * doc: update documentation with general content from tutorial (#61) * doc: incorporate core widget overview from tutorial * doc: incorporate content from Tutorial: Overview * doc: incorporate the tutorial content about layouts * doc: format markdown with prettier * doc: migrate remaining nui docs from tutorial wiki (#62) * chore: move flow-layout images into images dir * doc: add miglayout docs from tutorial wiki * doc: add skin docs from tutorial wiki * feat: Add multiple pointer logic (#60) Multiple items should now be interactable simultaneously, rather than sequentially. This allows, for example, for holding down two buttons at once on a touch screen. Input backends need to explicitly implement this, so existing behaviour should be preserved. * fix: fix UIButton not releasing when enabled (#64) Co-authored-by: Tobias Nett <skaldarnar@googlemail.com> Co-authored-by: jdrueckert <jd.rueckert@googlemail.com> Co-authored-by: BenjaminAmos <24301287+BenjaminAmos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
UIButtonis disabled whilst the mouse is being held over it, then theUIButtonwill still act as pressed even if the mouse button is released when it is re-enabled. The same applies if you release the button whilst it is disabled. The button only becomes un-pressed when you click it again. I have added a reproduction of this bug to my NUISamples project. The gif below shows this.Destination Sol on Android has several buttons that are used to control the player ship (touch screen controls). These buttons are typically held, rather than pressed, to indicate that an action should be taken (see MovingBlocks/DestinationSol#588). When using NUI buttons to control the player ship, this issue is particually pronouced.
This pull request slightly adjusts the interaction region logic for buttons. It ensures that the interaction region is still present if the button is in the
downstate and then correspondingly only enables the button on mouse release if the button is enabled.