resolved issue #2231 #2245
resolved issue #2231 #2245
Conversation
|
Can one of the admins please verify this patch? |
|
Refer to this link for build results (access rights to CI server needed): |
|
Just seemed like a fairly roundabout way to fix a bug, but if it works then it's probably good. :D |
| @@ -91,6 +92,10 @@ public Status tick(float deltaSeconds) { | |||
| LOG.warn("update of Task {} returned invalid state {}", this.getClass(), newStatus); | |||
| } | |||
| status = newStatus; | |||
| if(newStatus == Status.FAILURE || newStatus == Status.SUCCESS) { | |||
There was a problem hiding this comment.
Why is this better than calling onTerminate() in the corresponding switch cases?
There was a problem hiding this comment.
It could still be in the running state. Some of the test expect the onTerminate to be called without the state of the node to be in a terminated state. I guess the test can be modified to work in the other case.
Cervator
added
the
Category: Build/CI
|
Went ahead and merged this so PR checks will look less scary, even if maybe this isn't perfect yet. I added a note in #2070 to give it another pass in the future. Thanks! |
Contains
This pull request resolves issues relating to the behavior tree test failing.
How to test
run the unit test for logic/behavior.