feat: Add BlockAreac#distanceSquared #4621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pollend
reviewed
Apr 11, 2021
engine/src/main/java/org/terasology/engine/world/block/BlockArea.java
Outdated
Show resolved
Hide resolved
pollend
requested changes
Apr 11, 2021
engine/src/main/java/org/terasology/engine/world/block/BlockArea.java
Outdated
Show resolved
Hide resolved
pollend
requested changes
Apr 11, 2021
engine/src/main/java/org/terasology/engine/world/block/BlockArea.java
Outdated
Show resolved
Hide resolved
pollend
requested changes
Apr 11, 2021
engine/src/main/java/org/terasology/engine/world/block/BlockArea.java
Outdated
Show resolved
Hide resolved
|
@shadowasphodel2919 thanks for updating the PR. Please add a few test cases to https://github.com/MovingBlocks/Terasology/blob/develop/engine-tests/src/test/java/org/terasology/world/block/BlockAreaTest.java to ensure everything is working as expected. Once that is done, we should add the dual method for BlockRegion in a follow up PR to keep the APIs consistent. |
|
@skaldarnar thanks I am working upon it. |
pollend
reviewed
May 2, 2021
engine/src/main/java/org/terasology/engine/world/block/BlockArea.java
Outdated
Show resolved
Hide resolved
|
I have added the test cases for both the functions along with the changes to |
pollend
previously requested changes
May 9, 2021
engine-tests/src/test/java/org/terasology/world/block/BlockAreaTest.java
Outdated
Show resolved
Hide resolved
pollend
added
the
Type: Improvement
|
@skaldarnar @pollend are there any open issues from your side with this or can we resolve the conflicts and try to get this merged? |
skaldarnar
previously approved these changes
Jul 20, 2021
skaldarnar
changed the title
jdrueckert
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Terasology/CoreWorlds#27 (comment)
Added the
distanceSquared()function to theBlockAreafile.-> Implemented it by creating a calculate distance function