Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add commands for visual debugging (bounding boxes, etc.) #4857

Merged
merged 7 commits into from
Sep 10, 2021

Conversation

skaldarnar
Copy link
Member

@skaldarnar skaldarnar commented Aug 18, 2021

Contains

This PR adds a couple of debug commands to toggle debug rendering features such as bounding boxes (entities, chunks) or skeletal meshes.

All commands are of the form debug:<settings-name> to introduce a common, consistent pattern and simplify correlation with the actual settings entry.

How to test

  • debug:renderEntityBoundingBoxes entities such as sheep or deer (spawnPrefab deer in JS or MR) should be rendered with a white wireframe bounding box.
  • debug:renderChunkBoundingBoxe chunk bounding boxes should be rendered in a black wireframe mode (can also be toggled via keyboard shortcut)
  • debug:renderWireframe the whole world is rendered in wireframe mode (can also be toggled via keyboard shortcut)
  • debug:renderSkeletons the skeleton (animation rig) of entites should be rendered as white outline. Easy to test alongside the bounding box rendering for entities

@github-actions github-actions bot added the Type: Improvement Request for or addition/enhancement of a feature label Aug 18, 2021
@skaldarnar skaldarnar marked this pull request as ready for review September 6, 2021 20:49
@pollend
Copy link
Member

pollend commented Sep 8, 2021

maybe we should just have all extra debugging driven this way. we use all our F keys for debug.

@pollend pollend merged commit fbe2fad into develop Sep 10, 2021
@pollend pollend added this to the v5.2.0 milestone Sep 10, 2021
@skaldarnar skaldarnar deleted the feat/rendering-debug-commands branch September 10, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Request for or addition/enhancement of a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants