ci: fail checkstyle on all findings except warning.LOW #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrueckert
added
Category: Build/CI
|
Meh, that somehow does not work as expected 🤔 |
* we did not put enough effort into fixing pmd and spotbugs issues to apply these strict quality gates for them
|
I think I fixed the syntax errors @jdrueckert |
pollend
reviewed
Sep 12, 2021
| * <li><a href="https://docs.microsoft.com/en-us/windows-hardware/drivers/devtest/application-verifier">Application Verifier | ||
| * (<code>AppVerif.exe</code>)</a>, available from the Windows SDK</li> | ||
| * <li> | ||
| * <a href="https://docs.microsoft.com/en-us/windows-hardware/drivers/devtest/application-verifier">Application Verifier (<code>AppVerif.exe</code>)</a>, |
There was a problem hiding this comment.
any clue about getting rid of this LineLenghtCheck. sometimes its better to format this with one long line.
I think this is a lot more readable then trying to work out how to chop the line to the right length.
* <ul>
* <li><a href="https://docs.microsoft.com/en-us/windows-hardware/drivers/devtest/application-verifier">Application Verifier (<code>AppVerif.exe</code>)</a>,available from the Windows SDK</li>
* <li><a href="https://github.com/lowleveldesign/process-governor">Process Governor (<code>procgov</code>)</a>,an open source third-party tool</li>
* </ul>
There was a problem hiding this comment.
As @skaldarnar mentioned on Discord, for these "sometimes" cases there's annotations that allow exactly that: ignoring the check rule in a particular case.
|
maybe we can adjust the checkstyle warnings: https://checkstyle.sourceforge.io/property_types.html#SeverityLevel |
pollend
approved these changes
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the analysis stage only fails for findings of severity "error".
Findings of severities "warning.HIGH", "warning.NORMAL" and "warning.LOW" do not result in a failure.
This PR attempts to reduce the acceptable severity to "warning.LOW" only, all findings of higher severities should fail the build.