test: add NetworkMode setting to MTE #5037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keturn
added
Type: Improvement
keturn
force-pushed
the
test/mteNetworkMode
branch
from
3b245f5 to
36bbc05
Compare
stumble upon overlapping Engines instances in MTE :(
keturn
force-pushed
the
test/mteNetworkMode
branch
from
36bbc05 to
598aece
Compare
|
yes Jenkins, the test all pass, but we haven't added any tests that use this yet. Well, it might be possible to go ahead with this without waiting on networking's CoreRegistry removal by switching between just Well, it needs some tests written in any case. |
|
Some basic tests added. Seems okay probably. |
This was referenced Jun 1, 2022
# Conflicts: # engine-tests/src/main/java/org/terasology/engine/integrationenvironment/Engines.java
# Conflicts: # engine-tests/src/main/java/org/terasology/engine/integrationenvironment/jupiter/MTEExtension.java
jdrueckert
approved these changes
Jun 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows MTE tests to use the
networkModeargument to the@IntegrationEnvironmentto specify which network mode the engine will start in: none (local player only), server with local player, or server-only (i.e. headless).@IntegrationEnvironmentis a new annotation. The plan is for MTE settings to move there, as opposed to making an annotation per setting. (See Terasology/ModuleTestingEnvironment#76.)Fixes #5031
How to Test
No impact expected on existing servers or tests, as the default is unchanged.
You could start a server (headless and headed) and connect to it just to confirm.