chore(TypeHandlerLibrary)! make Serializer more type-safe #5049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Chore
keturn
force-pushed
the
chore/typeSafeSerializer
branch
from
518450c
to
4c11ecb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how necessary this is, but it's one of those things where I started pulling on a string while debugging and then I'm all caught up in a game of type-algebra sudoku.
This probably depends on a small change to nui-reflect.
The usage of
varis not purely aesthetic here, at least in some cases. There seem to be situations where it gives the type engine room to search more deeply than it does if you use wildcards with local variables yourself.Outstanding before merging