refactor(netork)!: rewrite ping logic #5106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have introduced type handlers for generic maps some time ago, and there is no need anymore to keep the ping information as separate lists. Therefore, refactor the internal storage of ping data to use a `Map<EntityRef, Long>`.
github-actions
bot
added
the
Type: Improvement
skaldarnar
added
the
Multiplayer
skaldarnar
force-pushed
the
topic/rewrite-ping-system
branch
from
56d2dc4 to
59ab883
Compare
…into PingComponent feat(nui): improve online players visuals
|
Tests out fine. The only thing not so great (yet) is the formatting in the ping info overlay. |
skaldarnar
changed the title
jdrueckert
previously approved these changes
Jul 13, 2023
engine/src/main/java/org/terasology/engine/network/ServerPingSystem.java
Outdated
Show resolved
Hide resolved
…ystem.java Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
skaldarnar
changed the title
skaldarnar
added
Breaking Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Started off with some boy-scout rule improvements while looking at the code, and ended in a bigger experiment on consolidating (unneccessary?) complexity in the logic around pings and ping subscriptions.
Also added a bunch of docstrings to improve the comprehensibility of the code.
How to test
Start a multiplayer game with multiple connected clients and ensure that the ping information in the UI still looks reasonable.
Outstanding before merging
n/a