feat: fix ExecutorCompletionService workaround in ChunkProcessingPipeline #5128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
This pull request removes the work-around in
ChunkProcessingPipeline
where it reflects into the internals of the built-inExecutorCompletionService
class. This is no longer possible with newer Java versions and was never guarenteed to work in the first place.Instead of making assumptions about
ExecutorCompletionService
, this pull request replaces the usage of the class with a new one specialised for dealing with chunks. Essentially, this makes sure that the submitted tasks are always of typePositionFuture
, as several other classes in the codebase depend on the task future being an instance of that type. I believe thatPositionFuture
is used for certain optimisations related to the chunk load order.This contributes to #3976.
How to test