Skip to content

Add weighting control in fit_velocities#1

Merged
jluastro merged 1 commit intomainfrom
wd1
Apr 3, 2024
Merged

Add weighting control in fit_velocities#1
jluastro merged 1 commit intomainfrom
wd1

Conversation

@wei-lingfeng
Copy link
Collaborator

No description provided.

@wei-lingfeng wei-lingfeng requested a review from mwhosek April 1, 2024 23:03
@mwhosek
Copy link
Collaborator

mwhosek commented Apr 2, 2024

Looks OK to me! Going to request that Jessica take a look too, just to be safe. We should consider implementing some end-to-end test functions to make sure the flystar output stays consistent when updates are applied.

@mwhosek mwhosek requested a review from jluastro April 2, 2024 22:33
Copy link
Collaborator

@jluastro jluastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@jluastro jluastro merged commit 84d6357 into main Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments