Drop Result #1858
Merged
Drop Result #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshinejr
approved these changes
May 14, 2019
There was a problem hiding this comment.
Awesome, yeah Alamofire 4 still imports Result AFAIK, but this will be removed with version 5 anyways. Thanks for taking care of it, @larryonoff 👍
LucianoPAlmeida
approved these changes
May 15, 2019
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## development #1858 +/- ##
===============================================
+ Coverage 92.12% 92.13% +<.01%
===============================================
Files 25 25
Lines 864 865 +1
===============================================
+ Hits 796 797 +1
Misses 68 68
Continue to review full report at Codecov.
|
|
Alright, it's green, it's merged! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops Result dependency.