update GGML_HIP_UMA #536
Open
update GGML_HIP_UMA #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the 2 changes needed for llamafile: - remove UMA build option - use it in all case if hipalloc failed with 'not have enough memory'
Merged
atelepov
approved these changes
Nov 2, 2024
|
@Djip007 Can this be merged now that it has been approved? |
|
For me with linux kernel > 6.10 it is less needed, but Yes it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the 2 changes needed for llamafile:
Note: with linux kernel 6.10+ hip_malloc use GGT memory for some APU (Ryzen 7940HS ...) so the limite size is easly configurable on linux with boot parameter. No more need for BIOS VRAM change.
#add at boot kernel param to have 16Go of GGT Memory. (default is 1/2 of free RAM) amdgpu.gttsize=16384Note2: With this patch/UMA we can use all RAM without config.
(#439 (comment) update)