Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call appropriate HIP API's for Driver Debug Logs #651

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

cjpais
Copy link
Collaborator

@cjpais cjpais commented Dec 4, 2024

This calls the appropriate HIP API's for the extra CUDA logging introduced recently.

Previously ggml-rocm.so would end up failing to compile due to cudaDriverGetVersion not being available on the HIP platform.

Copy link
Collaborator

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jart jart merged commit 9b03e32 into Mozilla-Ocho:main Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants