Skip to content

Commit

Permalink
Bump node to version 20 (#11773)
Browse files Browse the repository at this point in the history
* Run npm audit fix

* Bump node to version 20

* Update package-lock to node 20

* Bump visual regression testing node version

---------

Co-authored-by: Mavis Ou <mmmavis@users.noreply.github.com>
  • Loading branch information
jhonatan-lopes and mmmavis authored Jan 31, 2024
1 parent dd2d5d3 commit cb1317b
Show file tree
Hide file tree
Showing 6 changed files with 224 additions and 156 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/continous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
cache: "npm"
- name: Install Node Dependencies
run: npm ci
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
cache: "pip"
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
- name: Install Python Dependencies
run: pip install -r requirements.txt -r dev-requirements.txt
- name: Install Node Dependencies
Expand Down Expand Up @@ -157,7 +157,7 @@ jobs:
cache: "pip"
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
cache: "npm"
- name: Install Python Dependencies
run: pip install -r requirements.txt -r dev-requirements.txt
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/visual-regression-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
cache: "pip"
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
cache: "npm"
- name: Install Python Dependencies
run: pip install -r requirements.txt -r dev-requirements.txt
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# (Keep the version in sync with the node install below)
FROM node:18-bullseye-slim as frontend
FROM node:20-bullseye-slim as frontend

# Make build & post-install scripts behave as if we were in a CI environment (e.g. for logging verbosity purposes).
ARG CI=true
Expand Down Expand Up @@ -132,8 +132,8 @@ RUN apt-get update --yes --quiet && apt-get install --yes --quiet --no-install-r
RUN mkdir -p /etc/apt/keyrings && \
curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg

# Create deb repository for Node.js v18.x
RUN echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_18.x nodistro main" > /etc/apt/sources.list.d/nodesource.list
# Create deb repository for Node.js v20.x
RUN echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_20.x nodistro main" > /etc/apt/sources.list.d/nodesource.list

# Update and install Node.js
RUN apt-get update && apt-get install nodejs -y \
Expand Down
Loading

0 comments on commit cb1317b

Please sign in to comment.