localized form templates and updated instructions #11354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ozillaFoundation/foundation.mozilla.org into 11173-donate-help-fa-form-i18n
danielfmiranda
temporarily deployed
to
foundation-s-11173-dona-co8e89
danielfmiranda
commented
Nov 2, 2023
Comment on lines
54
to
63
| const localeMap = { | ||
| 'zh-CN': 'tfa_218', | ||
| 'zh-TW': 'tfa_218', | ||
| 'cs': 'tfa_219', | ||
| 'da': 'tfa_220', | ||
| 'nl': 'tfa_221', | ||
| 'en-CA': 'tfa_222', | ||
| 'en-GB': 'tfa_222', | ||
| 'en-US': 'tfa_222', | ||
| 'en-ZA': 'tfa_222', | ||
| 'fy-NL': 'tfa_221', | ||
| 'en': 'tfa_222', | ||
| 'fr': 'tfa_223', | ||
| 'de': 'tfa_224', | ||
| 'it': 'tfa_225', | ||
| 'ja': 'tfa_226', | ||
| 'pl': 'tfa_228', | ||
| 'pt-BR': 'tfa_229', | ||
| 'ru': 'tfa_230', | ||
| 'es-MX': 'tfa_231', | ||
| 'es-AR': 'tfa_231', | ||
| 'es-ES': 'tfa_231', | ||
| 'es-CL': 'tfa_231' | ||
| 'es': 'tfa_231', | ||
| } |
There was a problem hiding this comment.
Hi @mmmavis! As mentioned here, I have worked with stakeholders to update this list to language codes that are supported on the foundation site.
This update was done on FormAssembly, so we wont have to worry about updating this after a copy/paste. It will already be included!
danielfmiranda
changed the title
mmmavis
requested changes
Nov 2, 2023
| @@ -74,7 +69,7 @@ | |||
| </script></div> | |||
| <form method="post" action="https://mozillafoundation.tfaforms.net/api_v2/workflow/processor" class=" labelsAbove" id="12" role="form" enctype="multipart/form-data" style="padding:0;"> | |||
| <div class="oneField field-container-D labelsAbove " id="tfa_95-D"> | |||
| <label id="tfa_95-L" class="label preField" for="tfa_95">I need</label><br><div class="inputWrapper"><select aria-required="true" id="tfa_95" name="tfa_95" title="I need" class="required"><option value="">Please select...</option> | |||
| <label id="tfa_95-L" class="label preField" for="tfa_95">{% trans "I need" %}</label><br><div class="inputWrapper"><select aria-required="true" id="tfa_95" name="tfa_95" title="{% trans "I need" %}" class="required"><option value="">{% trans "Please select..." %}</option> | |||
| <option value="tfa_194" id="tfa_194" data-conditionals="#tfa_212,#submit_button,#tfa_214,#tfa_163" class="">Help with the donation form</option> | |||
There was a problem hiding this comment.
It would be great if we could show localized text for these dropdown options. Let's wrap them in trans
There was a problem hiding this comment.
Thanks for the feedback Mavis! This makes sense to me, I did not know that dropdown options can also be wrapped in trans! I have updated the PR, and re-requested review for whenever you have time 👍
danielfmiranda
temporarily deployed
to
foundation-s-11173-dona-co8e89
mmmavis
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to sample test page: https://donate-foundation-s-11173-dona-co8e89.mofostaging.net/en/help/
Related PRs/issues: #11173
Using #10589 for reference, this PR makes the same localization updates to the FormAssembly form found on the donate help page.