Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make link_to field required on LinkBlock #12083

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Make link_to field required on LinkBlock #12083

merged 4 commits into from
Mar 21, 2024

Conversation

jhonatan-lopes
Copy link
Contributor

@jhonatan-lopes jhonatan-lopes commented Mar 21, 2024 •
edited by data-sync-user
Loading

Description

link_to field was wrongly set as required=False on LinkBlock. This PR fixes that.

image

Link to sample test page:
Related PRs/issues:

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

┆Issue is synchronized with this Jira Story

danielfmiranda
danielfmiranda approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jhonatan-lopes! LGTM 🚀

@jhonatan-lopes jhonatan-lopes merged commit 7c9ba9e into main Mar 21, 2024
6 checks passed
@jhonatan-lopes jhonatan-lopes deleted the bugfix/TP-375/make-link-to-required branch March 21, 2024 20:49
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfmiranda danielfmiranda danielfmiranda approved these changes

Assignees
No one assigned
Labels
run visual regression tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhonatan-lopes @danielfmiranda