Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated donate banner JS to account for PNI if needed #13306

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Dec 11, 2024

Description

Link to sample test page:

This PR updates the donate banner JS file so the "close" button at the top right corner of the donate banner works on all pages, including PNI.

Steps to test:

  1. Visit https://foundation-s-hotfix-pni-wjuhyj.herokuapp.com/en/
  2. Note that the Donate Banner is rendering as expected.
  3. Click the X button at the top right corner of the donate banner, note that it closes as expected.
  4. Open your dev tools and navigate to "local storage". Delete the item with the key "donate banner dismiss day".
  5. Visit https://foundation-s-hotfix-pni-wjuhyj.herokuapp.com/en/privacynotincluded/
  6. Click the X button at the top right corner of the donate banner, note that it now closes as expected.
  7. If everything is working as expected, testing is complete!

┆Issue is synchronized with this Jira Story

@danielfmiranda danielfmiranda temporarily deployed to foundation-s-hotfix-pni-wjuhyj December 11, 2024 21:59 Inactive
@danielfmiranda danielfmiranda changed the title updated donate banner JS to account for PNI wrapper if needed updated donate banner JS to account for PNI if needed Dec 11, 2024
Copy link
Collaborator

@ramram-mf ramram-mf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel. Working as expected.

Copy link
Collaborator

@dlopezvsr dlopezvsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, worked as expected. LGTM, thanks @danielfmiranda!

@danielfmiranda danielfmiranda merged commit 059df85 into main Dec 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants