Set the default CSP directive to self (properly quoted this time) #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pomax
reviewed
Nov 15, 2018
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| {% block og-title %} | |||
| <meta property="og:title" content="privacy not included - {{ product.name }}" /> | |||
| <link rel="canonical" href="{{ request.scheme }}://{{ request.get_host }}{{ request.get_full_path }}" /> | |||
There was a problem hiding this comment.
Does this require canonical links for the homepage, too?
There was a problem hiding this comment.
I added this here because it's something Talk asks for specifically, and it's only on product pages.
There was a problem hiding this comment.
The block name doesn't quite make sense. I'm going to update that
Pomax
approved these changes
Nov 22, 2018
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2168
I've modified the default CSP directive, and I've added a cononical link tag to product pages. This should stop the logging from the browser about "self" and from talk about the missing tag.